Im really new to the game and would like some thoughts on an army Im been thinking of!

Warband 1 9/12
Gil-galad with Shield;
3 High Elf Warrior with Elf Bow;
2 High Elf Warrior with Shield; Spear;
4 King's Guard with Elven Blade; Shield;
----

Warband 2 10/12
Elladan and Elrohir with Heavy armour;
3 High Elf Warrior with Elf Bow;
3 High Elf Warrior with Elven Blade; Shield;
3 King's Guard with Shield; Spear;
----

So! 500 points, 21 Units. Some Shooting, spears, elven blades and good heroes!
Would like to have some veterans opinions on this list!

Speaking as a veteran of this faction I'll say this, the build of your army depends highly on what sort of battle you what to fight. At 500pts your could run a skirmishing force and you might have more luck with it over a line build. If you are expecting to or want to fight a head on clash of lines I'd advise making some changes to your set up.

First off I'd drop one of your big heroes in favor of a storm caller or Erestor. Granted your aren't like to see more then two warbands at this points level and numbers is something high elves always struggle with; but you have more then half your points tied up in big named heroes. If you were to replace Gil Galad with Erestor or Gildor you'd free up the points you need to fill up your warbands, deck out the twins and maybe gain a spell caster to boot.

Secondly I'd advise you to give all your archers spears so they can move to support if they start running out of targets to shoot. That and concentrate your archers into one warband, that way you don't wined up dragging your bowmen into combat range if you need to deploy your fighters on an objective.

Lastly I suggest trying to work a banner in if you can. I might seem like a bit of a point sink but it really helps the elves capitalize on their high fight by letting them get another change to roll a six. Against defense six strength four enemies you'll need to be winning most of your fights or risk losing by attrition alone.

_________________
"Draw your sword with a heavy heart, but swing it with a heavy hand"

I am actually fine with keeping either Gil-Galad or the twins. The twins allows a player to field 6 points of might and 3 attacks model. Since both Erestor and the stormcaller only have 1 might, I suggest to have Erestor and the twins. With this you will still have 7 might in the game.

Drop the Elven blades. If they have a shield, they do not need an elven blade. But you should still have a couple of elven armed with those blades and no shield; this is because Elves have no S4 units or multi-attack models. Having a couple of Elves in each warband that can wield a weapon 2 handed is almost a necessity to get rid of high defence models.

Thank you for your advise guys!
Been working with it and this is what ive been coming up with:

Warband 1 12/12
Elladan and Elrohir with Horse; Heavy armour;
9 High Elf Warrior with Shield; Spear;
2 High Elf Warrior with Elven Blade;
----
Warband 2 11/12
Erestor
7 High Elf Warrior with Elf Bow; Spear;
2 High Elf Warrior with Shield; Spear;
2 High Elf Warrior with Elven Blade;

495 pts, 25 units. Did not split the archers, Twins gets mounted!

Or this list
Warband 1 11/12
Elladan and Elrohir with Heavy armour;
8 High Elf Warrior with Shield; Spear;
2 High Elf Warrior with Elven Blade;
----
Warband 2 12/12
Erestor
5 High Elf Warrior with Elf Bow; Spear;
4 High Elf Warrior with Shield; Spear;
2 High Elf Warrior with Elven Blade;
1 High Elf Warrior with Banner;




496 pts, 25 units. Twins horses is gone and less archers but I added a banner.
Is this maybe better and/or should I think of something more?
Once again, thank you for all your help!

Thank you for your opinions! I have been working with the list again and got 2 alternative.
Warband 1 12/12
Elladan and Elrohir with Horse; Heavy armour;
8 High Elf Warrior with Shield; Spear;
3 High Elf Warrior with Elven Blade;
----
Warband 2 12/12
Erestor
4 High Elf Warrior with Elf Bow; Spear;
4 High Elf Warrior with Shield; Spear;
4 High Elf Warrior with Elven Blade;

This is my first list, Some bows, elven blades, Erestor and the twins.

Warband 1 12/12
Elladan and Elrohir with Heavy armour;
7 High Elf Warrior with Shield; Spear;
3 High Elf Warrior with Elven Blade;
1 High Elf Warrior with Banner;
----
Warband 2 11/12
Erestor
5 High Elf Warrior with Elf Bow; Spear;
4 High Elf Warrior with Shield; Spear;
2 High Elf Warrior with Elven Blade;

Here I pretty much dropped one unit and The horses for the twins for a banner!
Anything you feel is a must to change?
Once again, thank you for every advise!